This repository was archived by the owner on May 3, 2024. It is now read-only.
move numTries storage into run header#81
Merged
tomeichlersmith merged 3 commits intotrunkfrom Nov 6, 2023
Merged
Conversation
Storing the number of tries on a per-event basis means throwing away any tries that occur _after_ the last event that ends up in being successful and written to the output file. This leads to an inaccurate EoT estimation and so we are dropping it in favor of storing the number of tries in the run header at the completion of a Production Mode run.
this highlights its importance to luminosity/eot calculations and also emphasizes to downstream processors that they shouldn't modify it (just like how they shouldn't modify run number, run start, and run end unless they know what they are doing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in the re-opening of #69 , we need to store the number of tries separate from the events since there can be tries that are not connected to a serialized event (ones after the last successful event that ends up in the output file). This update keeps the refactoring to the EventHeader but removes the new version since there are now no changes relative to the current event header outside of the refactoring which is not important to the ROOT dictionary.
I've checked and documented how the new RunHeader interops with the current RunHeader and so this is good to go.