Merged
Conversation
tvami
approved these changes
Mar 10, 2026
Member
|
I don't think you need to caveat your notes since its not on trunk yet. I would add the minimum required version for the complete feature set since I could forsee someone trying to visualize a geometry using a pre-compiled version of ldmx-sw. |
Member
|
I also cut 4.6.3 yesterday [your today] so if you change it, change it to 4.6.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added documentation to explain how to use g4-vis.
Originally a part of LDMX-Software/ldmx-sw#1987, based on a suggestion from @tvami, I'm opting to move this documentation to the tutorial page.
WARNING - some of this documentation is based on work in the PR which is currently active in ldmx-sw, and won't work on trunk. Also, should I add somewhere in the documentation that the new vis tools won't work on releases older than 4.6.3 (hopefully we can release them in the next version)?