Skip to content

issue-371 added destructor#379

Merged
tomeichlersmith merged 2 commits intomainfrom
371-virtual-destructor-fix
Mar 18, 2026
Merged

issue-371 added destructor#379
tomeichlersmith merged 2 commits intomainfrom
371-virtual-destructor-fix

Conversation

@andpet1324
Copy link
Copy Markdown
Contributor

@andpet1324 andpet1324 commented Mar 17, 2026

No description provided.

@andpet1324 andpet1324 linked an issue Mar 17, 2026 that may be closed by this pull request
Delete-type-mismatch when exiting pftool with fiberless config #371
Closed
@tomeichlersmith
Copy link
Copy Markdown
Member

tomeichlersmith commented Mar 17, 2026

I'm going to merge this anyway because its best practice to have virtual destructors for abstract base classes, but I'm curious if this resolves #371 - do you still see the complaint from the address sanitizer?

@andpet1324
Copy link
Copy Markdown
Contributor Author

andpet1324 commented Mar 18, 2026

I'm going to merge this anyway because its best practice to have virtual destructors for abstract base classes, but I'm curious if this resolves #371 - do you still see the complaint from the address sanitizer?

This does resolve #371 !

@tomeichlersmith tomeichlersmith merged commit 44b5186 into main Mar 18, 2026
@tomeichlersmith tomeichlersmith deleted the 371-virtual-destructor-fix branch March 18, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomeichlersmith tomeichlersmith tomeichlersmith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete-type-mismatch when exiting pftool with fiberless config

2 participants

@andpet1324 @tomeichlersmith