fix: k6 integration test picks up wildcard sentinel from list_actions#255
Merged
fix: k6 integration test picks up wildcard sentinel from list_actions#255
Conversation
…test The list_actions API returns a wildcard sentinel entry (id: "n/a") for U256::zero(), which was being picked up by listActionsBody[0]?.id. This caused updateActionMetadata to reject the request with "Cannot update action with hash 0x0". Find by name instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a k6 correctness integration test failure caused by the /list_actions API including a wildcard sentinel entry (id: "n/a") alongside real actions, which the test previously (and incorrectly) selected as the target action ID.
Changes:
- Update the k6 integration test to select the action by a specific name (
"hello-world") rather than taking the firstlist_actionsarray element. - Extend the parsed
list_actionsitem shape to includenameso the test can search for the intended action.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_actionsAPI returns a wildcard sentinel entry withid: "n/a"(representingU256::zero()— "Any action") alongside real actionslistActionsBody[0]?.id, which picked up this sentinel"n/a"was passed toupdateActionMetadataashashed_cid, the server parsed it as0x0and rejected it with "Cannot update action with hash 0x0""hello-world") instead of taking the first array elementTest plan
k6-correctness / correctnessjob passes in CI on this branch🤖 Generated with Claude Code