Skip to content

fix(CPL-316): clarify ChainSecured conversion modal copy#336

Merged
GTC6244 merged 1 commit into
nextfrom
feature/cpl-316-convert-to-chain-secured-modal-update
May 7, 2026
Merged

fix(CPL-316): clarify ChainSecured conversion modal copy#336
GTC6244 merged 1 commit into
nextfrom
feature/cpl-316-convert-to-chain-secured-modal-update

Conversation

@GTC6244
Copy link
Copy Markdown
Contributor

@GTC6244 GTC6244 commented May 7, 2026

Summary

CPL-316 — the "Convert to ChainSecured" confirmation modal still read like a delete dialog and didn't mention that the wallet has to sign to prove ownership.

  • Title: Confirm deleteConfirm ownership change
  • Button: DeleteConvert
  • Body adds: "You will be asked to sign a message with your wallet to prove ownership"

The shared confirmDelete() now takes an optional { title, confirmLabel }. Defaults preserve the existing "Confirm delete" / "Delete" wording, so the actions/keys/groups callers are unchanged.

Files

  • lit-static/dapps/dashboard/auth.js — pass new title and button label when invoking the convert flow
  • lit-static/dapps/dashboard/ui-utils.js — extend confirmDelete(message, opts) and reset title/button text on every call so state doesn't leak between invocations

Notes

  • Diff is 9 lines across 2 files. No backend, schema, or contract changes. No new test framework in this dashboard area, so no automated coverage added.
  • The dialog body uses textContent; \n\n collapses in .modal-body. That's pre-existing behavior — happy to switch the body to white-space: pre-line in a follow-up if real paragraph breaks are wanted.

Test plan

  • Sign in with an API key, click "Convert to ChainSecured" in the account menu
  • Verify modal title reads "Confirm ownership change", action button reads "Convert", and body mentions signing to prove ownership
  • Cancel returns to the dashboard with no state change
  • Open a delete confirm (e.g., delete a usage key) and verify it still says "Confirm delete" / "Delete"

Linear: https://linear.app/litprotocol/issue/CPL-316/convert-to-chain-secured-modal-update

Title now reads "Confirm ownership change" and the action button reads
"Convert" instead of "Delete". The body mentions that the wallet will be
asked to sign a message to prove ownership.

Extends confirmDelete() with an optional { title, confirmLabel } so other
delete callers keep their existing wording.
@GTC6244 GTC6244 requested review from a team and Copilot May 7, 2026 02:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Lit dashboard’s shared confirmation modal so the “Convert to ChainSecured” flow no longer reads like a delete dialog and explicitly mentions the wallet signature needed to prove ownership.

Changes:

  • Extend confirmDelete(message, opts) to optionally override the modal title and confirm button label (with defaults preserving existing delete wording).
  • Update the ChainSecured conversion flow to use the new modal title/button copy and add the “sign a message” explanation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lit-static/dapps/dashboard/ui-utils.js Adds optional opts to confirmDelete and resets title/button text on each invocation to avoid cross-invocation UI state leakage.
lit-static/dapps/dashboard/auth.js Uses the updated confirmDelete options for the “Convert to ChainSecured” confirmation copy (title, button label, and body text).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GTC6244 GTC6244 merged commit 83073c1 into next May 7, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants