fix(CPL-316): clarify ChainSecured conversion modal copy#336
Merged
GTC6244 merged 1 commit intoMay 7, 2026
Conversation
Title now reads "Confirm ownership change" and the action button reads
"Convert" instead of "Delete". The body mentions that the wallet will be
asked to sign a message to prove ownership.
Extends confirmDelete() with an optional { title, confirmLabel } so other
delete callers keep their existing wording.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Lit dashboard’s shared confirmation modal so the “Convert to ChainSecured” flow no longer reads like a delete dialog and explicitly mentions the wallet signature needed to prove ownership.
Changes:
- Extend
confirmDelete(message, opts)to optionally override the modal title and confirm button label (with defaults preserving existing delete wording). - Update the ChainSecured conversion flow to use the new modal title/button copy and add the “sign a message” explanation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lit-static/dapps/dashboard/ui-utils.js |
Adds optional opts to confirmDelete and resets title/button text on each invocation to avoid cross-invocation UI state leakage. |
lit-static/dapps/dashboard/auth.js |
Uses the updated confirmDelete options for the “Convert to ChainSecured” confirmation copy (title, button label, and body text). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CPL-316 — the "Convert to ChainSecured" confirmation modal still read like a delete dialog and didn't mention that the wallet has to sign to prove ownership.
Confirm delete→Confirm ownership changeDelete→ConvertThe shared
confirmDelete()now takes an optional{ title, confirmLabel }. Defaults preserve the existing "Confirm delete" / "Delete" wording, so the actions/keys/groups callers are unchanged.Files
lit-static/dapps/dashboard/auth.js— pass new title and button label when invoking the convert flowlit-static/dapps/dashboard/ui-utils.js— extendconfirmDelete(message, opts)and reset title/button text on every call so state doesn't leak between invocationsNotes
textContent;\n\ncollapses in.modal-body. That's pre-existing behavior — happy to switch the body towhite-space: pre-linein a follow-up if real paragraph breaks are wanted.Test plan
Linear: https://linear.app/litprotocol/issue/CPL-316/convert-to-chain-secured-modal-update