Skip to content

Conversation

@FedericoAmura
Copy link
Contributor

@FedericoAmura FedericoAmura commented Oct 9, 2024

Description

This PR requires only the threshold nodes to sign sessions as it uses BLS, not ECDSA. Also fixes a check that was discarding node responses with an index value of 0 because it is considered falsy in JS

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests validate this part of code (failed before the index fix)
  • Locally with a script that uses PKPs and LAs with session keys

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@FedericoAmura FedericoAmura self-assigned this Oct 9, 2024
@FedericoAmura FedericoAmura marked this pull request as draft October 9, 2024 15:20
@FedericoAmura FedericoAmura marked this pull request as ready for review October 9, 2024 15:57
Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@FedericoAmura FedericoAmura merged commit aa860a8 into master Oct 9, 2024
5 checks passed
@FedericoAmura FedericoAmura deleted the feature/lit-3946-wait-for-threshold-nodes-when-signing-session-keys branch October 9, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants