Skip to content

feat: only wait for threshold nodes when signing session keys #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024
Merged

feat: only wait for threshold nodes when signing session keys #676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f2ba1b
feat: only wait for threshold nodes when signing session keys which u…
FedericoAmura Oct 9, 2024
76d813e
fix: don't discard node response with index 0 due to being a falsy va…
FedericoAmura Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/lit-node-client-nodejs/src/lib/lit-node-client-nodejs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1869,7 +1869,7 @@ export class LitNodeClientNodeJs
res = await this.handleNodePromises(
nodePromises,
requestId,
this.connectedNodes.size
this.config.minNodeCount
);
log('signSessionKey node promises:', res);
} catch (e) {
Expand Down Expand Up @@ -1934,7 +1934,11 @@ export class LitNodeClientNodeJs
for (const field of requiredFields) {
const key: keyof BlsResponseData = field as keyof BlsResponseData;

if (!data[key] || data[key] === '') {
if (
data[key] === undefined ||
data[key] === null ||
data[key] === ''
) {
log(
`[signSessionKey] Invalid signed data. "${field}" is missing. Not a problem, we only need ${this.config.minNodeCount} nodes to sign the session key.`
);
Expand Down
Loading