Feature/jss 29 feature add naga uptime bot #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d endpoint testing - Added health check initialization and management for Naga networks. - Implemented tests for key functionalities: Handshake, PKP Sign, Sign Session Key, Execute JS, and Decrypt. - Integrated logging to Lit Status backend for monitoring. - Created GitHub Actions workflow for automated health checks on push and manual triggers. - Updated package.json and pnpm-lock.yaml for new dependencies and scripts.
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a standalone Naga health check system that validates core Lit Protocol endpoints and reports to the Lit Status backend. The system performs automated health monitoring with minimal chain interactions and is currently triggered on pushes to the feature branch with scheduled runs prepared but disabled.
Key changes:
- Implements a lightweight health check runner with 5 core endpoint tests (handshake, PKP sign, session key signing, Lit Actions execution, and encryption/decryption)
- Adds GitHub Actions workflow for automated testing with environment-specific configurations
- Integrates with
@lit-protocol/lit-status-sdkfor monitoring and alerting
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/e2e/src/health/index.ts | Main health check runner with status backend integration and test orchestration |
| packages/e2e/src/health/health-init.ts | Lightweight initialization module for minimal chain interactions during health checks |
| packages/e2e/src/health/README.md | Comprehensive documentation covering usage, configuration, and troubleshooting |
| packages/e2e/src/health/NagaHealthManager.ts | Health check test implementations for the 5 core endpoints |
| package.json | Added health check npm scripts and lit-status-sdk dependency |
| .github/workflows/release.yml | Updated branch reference handling for release workflow |
| .github/workflows/health-checks.yml | GitHub Actions workflow for automated health check execution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| console.log('═══════════════════════════════════════'); | ||
| console.log('🏥 Naga Health Check Starting'); | ||
| console.log('═══════════════════════════════════════'); |
There was a problem hiding this comment.
The comment mentions 'ESM compatibility' but doesn't explain why dynamic import is necessary here or what compatibility issue it solves. Consider clarifying the specific compatibility concern.
Suggested change
| console.log('═══════════════════════════════════════'); | |
| // Initialize Lit Status Client. | |
| // @lit-protocol/lit-status-sdk is only available as an ESM module. | |
| // To import it from this (CommonJS or non-ESM) context, we must use dynamic import. |
Comment on lines
+43
to
+44
|
|
||
| /** |
There was a problem hiding this comment.
These constants lack documentation about the units (ETH) and rationale for the specific amounts chosen for health checks.
Suggested change
| /** | |
| // Configuration constants | |
| /** | |
| * Amount of ETH (in units of ETH) to fund the test account on live networks. | |
| * Chosen as 0.01 ETH to ensure enough balance for basic health check transactions | |
| * (e.g., PKP minting, small contract interactions), while minimizing cost and risk. | |
| */ | |
| const LIVE_NETWORK_FUNDING_AMOUNT = '0.01'; | |
| /** | |
| * Amount of ETH (in units of ETH) to deposit into the ledger for health checks. | |
| * Set to 2 ETH to guarantee sufficient balance for all required test operations, | |
| * including PKP minting and other on-chain actions, without risk of depletion. | |
| */ |
Comment on lines
+150
to
+164
| const litActionCode = ` | ||
| (async () => { | ||
| const { sigName, toSign, publicKey } = jsParams; | ||
| const { keccak256, arrayify } = ethers.utils; | ||
|
|
||
| const toSignBytes = new TextEncoder().encode(toSign); | ||
| const toSignBytes32 = keccak256(toSignBytes); | ||
| const toSignBytes32Array = arrayify(toSignBytes32); | ||
|
|
||
| const sigShare = await Lit.Actions.signEcdsa({ | ||
| toSign: toSignBytes32Array, | ||
| publicKey, | ||
| sigName, | ||
| }); | ||
| })();`; |
There was a problem hiding this comment.
The inline Lit Action code string is complex and could be moved to a separate constant or file for better maintainability and readability.
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT