refactor(workflows): consolidate release logic into e2e-naga.yml and … #944
+65
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove release.yml
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates release logic from a separate release.yml workflow into the existing e2e-naga.yml workflow. The release process now runs as a job within the E2E workflow after all matrix tests complete successfully.
- Removes the standalone release.yml workflow that was triggered by workflow_run events
- Adds a release job to e2e-naga.yml that runs after E2E tests pass
- Maintains the same release functionality using changesets/action@v1
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | Complete removal of standalone release workflow |
| .github/workflows/e2e-naga.yml | Addition of release job with consolidated release logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Anson <ansonox@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
naga/canary-naga, the new release job only runs after all E2E matrix runs succeed.- If it finds any, it opens/updates the changeset-release/ PR.
- If none are present, it exits cleanly (no PR, no ❌).