Fix incomplete Release 2.8.0 with Argument must be type #136
Closed
BenjaminLeibinger wants to merge 19 commits intoLKDevelopment:masterfrom
Closed
Fix incomplete Release 2.8.0 with Argument must be type #136BenjaminLeibinger wants to merge 19 commits intoLKDevelopment:masterfrom
BenjaminLeibinger wants to merge 19 commits intoLKDevelopment:masterfrom
Conversation
merge original
fix guzzle client
fixing public net
…e wrong type and breaks the library
Contributor
|
@LKaemmerling any chance, to get this merged/released in the near future? We have some internal processes where we rely on fixes made in 2.8.0 but since then the library is completely unusable. |
LKaemmerling
added a commit
that referenced
this pull request
Jun 5, 2025
LKaemmerling
added a commit
that referenced
this pull request
Jun 5, 2025
Collaborator
|
Superseeded by #137 thank you for your help and bringing this up to my attention. I just released the fix as v2.8.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the update to release 2.8.0 our application shows the Error:
LKDev\HetznerCloud\Models\Model::__construct(): Argument \#1 ($httpClient) must be of type ?GuzzleHttp\Client, LKDev\HetznerCloud\Clients\GuzzleClient given, called in /admin/vendor/lkdevelopment/hetzner-cloud-php-sdk/src/HetznerAPIClient.php on line 231#130 starts to fix the issue but only for the HetznerAPIClient.php and Model.php.
Many more classes has the GuzzleClient / Client as Argument.
This pull request should fix the issue.