Abort logic for harbor trajectories#28
Open
nightlessbaron wants to merge 2 commits into
Open
Conversation
|
It seems the precommit issues causing the tests to fail are pre-existing? Why didn't tests fail on the recent commit? Any idea @DavidBellamy ? |
Collaborator
|
This is upstream CI failing because some (16) unrelated files made their way into our prod branch without undergoing pre commit. Those files don't respect ruff/black. Run pre-commit run --all-files On the prod branch and it'll resolve this CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds abort-signal propagation for harbor trajectories. When the rollout finishes with
finish_reason == "abort", the session server sets anx-sglang-aborted: 1response header so the agent can stop immediately.This is needed because some
litellmversions remap"abort"→"stop"/"tool_calls", masking the finish reason; reading the raw response header is the only reliable cross-version detection path.This commit was split out of PR #17 (
steps-metrics) into its own branch so it can be reviewed and merged independently intoprod.Changes
miles/rollout/session/sessions.py: emitx-sglang-abortedheader on abort (+8 lines).🤖 Generated with Claude Code