Skip to content

Conversation

@DzmitryPihulski
Copy link
Collaborator

cli updated

@DzmitryPihulski DzmitryPihulski self-assigned this Dec 8, 2025
@DzmitryPihulski DzmitryPihulski linked an issue Dec 8, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 90.83333% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
llmsql/_cli/inference.py 91.78% 6 Missing ⚠️
llmsql/__main__.py 0.00% 4 Missing ⚠️
llmsql/_cli/llmsql_cli.py 93.75% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@DzmitryPihulski DzmitryPihulski added the enhancement New feature or request label Dec 8, 2025
Copy link
Collaborator

@Quarol Quarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running on windows 11 failed (command used: llmsql --help.

The reason is: vLLM is ONLY supportend on Linux, so any import causes the crash.
We need to do a workaround (always making sure only transformers run).
My proposed changed are pushed onto the branch in question.

Another issue is that if we keep provider as a flag (--method) then we will have overload of disjoined flags for both options - vllm and transformers.

Hence my suggestions (in the latest commit):

  • vllm and transormers became subcommands - they are not under --method flag anymore
  • I did a workaround that does lazy import if linux is detected. It means if other OS is used then vllm_interface will NOT be imported - so there is no crash.

Additional problem (commands ran on my own PC):
CLI is very slow - llmsql --help comm and takes about 6 seconds to output message.

…nd "vllm" became subcommands instead of being part of the "--method" flag.
@Quarol Quarol self-assigned this Dec 12, 2025
@Quarol Quarol self-requested a review December 12, 2025 22:17
@Quarol
Copy link
Collaborator

Quarol commented Dec 12, 2025

Please, check the latest commit @DzmitryPihulski . If I got ur "ok", then I will approve the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature add: CLI commands

3 participants