preliminary refactoring for the Multi-Threading support #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
artpol84
force-pushed
the
topic/pre_mt_refactor
branch
2 times, most recently
from
07f5013 to
67f5f72
Compare
artpol84
commented
Jun 12, 2019
artpol84
force-pushed
the
topic/pre_mt_refactor
branch
3 times, most recently
from
29384de to
e8170d9
Compare
cchambreau
requested changes
Jun 27, 2019
Collaborator
cchambreau
left a comment
cchambreau
left a comment
There was a problem hiding this comment.
Getting rid of mpiPi.h.in looks good, but could we get the STACKDEPTH and PACKAGE_BUGREPORT variables into mpiPconfig.h.in?
artpol84
commented
Jun 27, 2019
Contributor
Author
Good catch! Fixed |
artpol84
force-pushed
the
topic/pre_mt_refactor
branch
from
69517fa to
8e883a2
Compare
artpol84
added a commit
to artpol84/mpiP
that referenced
this pull request
Jun 27, 2019
See: LLNL#12 (review) Signed-off-by: Artem Polyakov <artpol84@gmail.com>
Contributor
Author
@cchambreau actually, it is not fixed. |
Contributor
Author
|
I suggest to merge #16 first and I'll rebase on top of it. |
artpol84
force-pushed
the
topic/pre_mt_refactor
branch
from
8e883a2 to
57d0ddb
Compare
Contributor
Author
|
This PR is now rebased on top of #16 and is using updated configury logic. |
artpol84
force-pushed
the
topic/pre_mt_refactor
branch
2 times, most recently
from
f4ca0a0 to
218a0e5
Compare
* Rename configure.in to configure.ac as autoreconf suggests * Switch from the custom-modified configure/mpiPconfig.h.in to the auto-generated by autoreconf * Modify few config vars to prepare to get rid of mpiPi.h.in Signed-off-by: Artem Polyakov <artpol84@gmail.com>
Signed-off-by: Artem Polyakov <artpol84@gmail.com>
Signed-off-by: Artem Polyakov <artpol84@gmail.com>
Extract the per-thread part from the global state. A per-thread portion includes the data collected at MPI_x invocation that can happen concurrently, i.e.: * Callsite information * Collectives statistics * Point-to-point statistics * Statistics collection on/off has also be per-thread Signed-off-by: Artem Polyakov <artpol84@gmail.com>
Signed-off-by: Artem Polyakov <artpol84@gmail.com>
artpol84
force-pushed
the
topic/pre_mt_refactor
branch
from
218a0e5 to
720702c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: