added bindings for greedy module #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chldkdtn
requested review from
bumpwy,
chldkdtn,
dreamer2368 and
siuwuncheung
ckendrick
force-pushed
the
pd_feature/greedy
branch
from
8c82e78 to
4547bd0
Compare
pravija12345
commented
Jan 4, 2024
ckendrick
approved these changes
Jan 4, 2024
Collaborator
ckendrick
left a comment
ckendrick
left a comment
There was a problem hiding this comment.
Approving on behalf of @pravija12345 since they are the owner of the PR and cannot approve.
suparnob100
approved these changes
May 30, 2024
ckendrick
force-pushed
the
pd_feature/greedy
branch
from
4547bd0 to
89a9fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds bindings for the greedy sampler classes (
GreedySampler,GreedyRandomSampler, andGreedyCustomSampler) to thepylibROM.algo.greedymodule.Tests for the new greedy module bindings can be run with
pytest tests/test_pyGreedyCustomSampler.py.