Skip to content

Conversation

@ckendrick
Copy link
Collaborator

This fixes some overloads for the Matrix class when used with distributed matrices or vectors.

For example, the following example would fail when A and C are pre-defined and distributed:

import numpy as np
import pylibROM.linalg as linalg

A = linalg.Matrix(5, 3, True)
A[0,0] = 1.; A[1,1] = 1.; A[2,2] = 1.
B = linalg.Matrix(3, 5, False)
B[0,0] = 1.; B[1,1] = 1.; B[2,2] = 1.
C = linalg.Matrix(3,3,True)
C = A.mult(B)

However, the A.mult(B, C) variation of this worked as expected. Bindings for other Matrix functions using similar syntax to C = A.mult(B) with distributed inputs are now fixed.

@ckendrick ckendrick requested review from chldkdtn and ptranq July 17, 2024 21:44
@chldkdtn
Copy link
Collaborator

If this is ready for review, please label it as RFR.

@ckendrick ckendrick merged commit 2840d1e into main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants