Rename FxMixer to Mixer

[gityssh]

This PR aims to rename FxMixer to Mixer, as decided in #6089 and #5592.

[JohannesLorenz]

The code can not compile due to this:

In Engine.h, you use static Mixer * Mixer(). This means you define a function with the same name as your class. Also, note that our coding conventions imply that class members (like the Mixer function) must use camelCase.

Same issue in GuiApplication.h with function MixerView.

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Windows

• Windows 32-bit: lmms-1.3.0-alpha.1.200%2Bge63e2f0bb-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha.1.200%2Bge63e2f0bb-mingw-win64.exe (build link)
• Windows 32-bit: lmms-1.3.0-alpha-msvc2017-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha-msvc2017-win64.exe (build link)

Linux

• Linux (AppImage): lmms-1.3.0-alpha.1.200%2Bge63e2f0bb-linux-x86_64.AppImage (build link)

macOS

• macOS : lmms-1.3.0-alpha.1.200%2Bge63e2f0bb-mac10.14.dmg (build link)

🤖

{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://15475-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.200%2Bge63e2f0bb-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15475?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://15479-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.200%2Bge63e2f0bb-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15479?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/myrfnb4ivjumwf2q/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/42123895"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/30336pb8yemdsbmu/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/42123895"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://15478-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.200%2Bge63e2f0bb-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15478?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://15477-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.200%2Bge63e2f0bb-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15477?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "abf64c976adf50509318eed35368d534a70574db"}

[JohannesLorenz]

Only 4 comments added.

Also, don't forget the stuff from Discord (e.g. the "Send to FX channel" should be "Send to Mixer channel", and the "FX" in InstrumentWindow should be "CH", ...).

[JohannesLorenz]

Additional note: The submodule "doc/wiki" contains multiple occurrences of "fx", "Fx" or "FX". Those should be fixed, too.

[JohannesLorenz]

Only 4 new comments, and the remaining wiki changes.

[JohannesLorenz]

Code is OK, except remaining wiki (Becoming-a-Theme-Developer.md, LMMS-Architecture.md)/GitBook changes.

Basic tests done, all OK.

[Spekular]

Review limitations:

• Only checked line diffs, no real bigger picture considerations
• Filtered out all changes to mmp, mpt, ts, and xpf files

[Spekular]

An additional request: In the comments for the upgrade routines, please either change "savings" to "project files", or omit it entirely.

I would also suggest moving all the upgrades into one function (upgrade_mixerRename) with a top level comment // Remove FX prefix from mixer and related nodes. The current comments about nodenames could then be moved to inside this function. However, before you do this I'd want to confirm with someone else (e.g. @JohannesLorenz) that they're not opposed.

[Spekular]

LGTM.

[JohannesLorenz]

@yashraj466 Spekular and me think that the PR is good. Do you want us to merge this, or do you still want to do more on this PR?

[gityssh]

@yashraj466 Spekular and me think that the PR is good. Do you want us to merge this, or do you still want to do more on this PR?

Okey 👍

[JohannesLorenz]

@yashraj466 Merged. Thanks a lot for your help!

[gityssh]

@yashraj466 Merged. Thanks a lot for your help!

Welcome 😃