Update crash01, cello01, e-organ01 to shorter files

[Monospace-V]

Fixes #7815
As per mediainfo, the new files seem to have a shorter length than the original (eg, crash01.ogg shows as 924 ms instead of 1311 ms). This is in line with how LMMS stable 1.2, the most commonly downloaded version of LMMS, loads these files.

I have exported them at quality 5 through Audacity so the new files are similar in filesize to the old ones. There seems to be no audible reduction in quality.

Using the shorter files may cause issues with some projects, but it has been determined that using the longer files will cause issues with more projects.

[sakertooth]

Did a quick test, the quality of the files seem fine. Both my build and LMMS master show 923ms for crash01.ogg for some reason, so I am guessing the bug is in another version? I'm not sure, but I trust that you are aware of any of the fixes the PR will bring, and it does not seem harmful to me either.

[bratpeki]

Same, I feel no need to test this. I'll just download the binaries and check they play fine. Please link to the Discord chat where this was discussed, though.

[Monospace-V]

Please link to the Discord chat where this was discussed, though.

Sure.
https://discord.com/channels/203559236729438208/1353847123539394560 is the relevant post thread in dev-forum.

[Monospace-V]

It seems there is at least some demand for keeping the longer files, for instance in the case of crash01 as crash01_long.ogg, so that the user may switch to it if it is necessary.
If this is something we are good with I can figure out how to get the longer file into an ogg.

[bratpeki]

There are other crash cymbals out there 🤣

[Monospace-V]

There are other crash cymbals out there 🤣

This is true.

Other than that suggestion, there is nothing to say. It seems to work as expected with projects made in stable, and it is my suggestion this be merged soon to avoid more instances of users expecting the longer sound beyond what we have already risked.

[allejok96]

Just curious, the bug report mentions 8 other files with invalid metadata. Are there any reason to update those too?

[Monospace-V]

Just curious, the bug report mentions 8 other files with invalid metadata. Are there any reason to update those too?

No.
Their lengths have been found to be consistent.

[bratpeki]

Why is this held up?

[messmerd]

According to Tresf, these samples have validation errors:

Validation failed for: ~/lmms/data/samples/drums/bassdrum01.ogg
Validation failed for: ~/lmms/data/samples/drums/bassdrum04.ogg
Validation failed for: ~/lmms/data/samples/drums/clap01.ogg
Validation failed for: ~/lmms/data/samples/drums/crash01.ogg
Validation failed for: ~/lmms/data/samples/drums/hihat_opened02.ogg
Validation failed for: ~/lmms/data/samples/drums/kick_hardcore01.ogg
Validation failed for: ~/lmms/data/samples/drums/shaker01.ogg
Validation failed for: ~/lmms/data/samples/drums/snare01.ogg
Validation failed for: ~/lmms/data/samples/instruments/cello01.ogg
Validation failed for: ~/lmms/data/samples/instruments/e_organ01.ogg
Validation failed for: ~/lmms/data/samples/misc/applause01.ogg

From what I understand, this PR only fixes the 3 samples which have a different length than the original.

Why not fix the validation errors for the remaining samples as well? Even if they do not misbehave at the moment, maybe they will in the future, so we might as well be thorough and fix all the samples.

[Monospace-V]

Why not fix the validation errors for the remaining samples as well? Even if they do not misbehave at the moment, maybe they will in the future, so we might as well be thorough and fix all the samples.

I can look into and work on them in a separate PR. I am going to be very busy for the next few weeks, and am unlikely get to the rest of the samples before this can be merged independently anyway.