Mallets. SilenceAllNotes() on instrument switch.

[zonkmachine]

Fixed the noise on switching instrument. This is apparent especially when switching from Tubular Bells to Uniform Bar.

[PhysSong]

This is apparent especially when switching from Tubular Bells to Uniform Bar.

I looked at the malletsInstrument constructor and found that the volume multiplier is different among presets. Tubular Bells has the smallest value and Uniform Bar has the largest one.

lmms/plugins/stk/mallets/mallets.cpp

Lines 110 to 116 in 032c324

	// TubeBell
	m_presetsModel.addItem( tr( "Tubular Bells" ) );
	m_scalers.append( 1.8 );
	// BandedWG
	m_presetsModel.addItem( tr( "Uniform Bar" ) );
	m_scalers.append( 25.0 );

The problem is that Mallets uses the global multiplier. If we pass the multiplier to malletsSynth and use it, this workaround may be removed.

[zonkmachine]

Cool!

[zonkmachine]

If we pass the multiplier to malletsSynth and use it, this workaround may be removed.

Do you mean in a similar way to how we send pitch information in setFrequency() but for volume?

lmms/plugins/stk/mallets/mallets.h

Lines 115 to 121 in 8679f79

	inline void setFrequency( const StkFloat _pitch )
	{
	if( m_voice )
	{
	m_voice->setFrequency( _pitch );
	}
	}

[PhysSong]

Do you mean in a similar way to how we send pitch information in setFrequency() but for volume?

I'd rather set the value in the malletsSynth constructor.