VST fixes and improvements

[DomClark]

d2854f6 resolves #4802
b2a30c2 fixes #4802 (comment)
fed062a fixes #4843
510d0b9 fixes #4861

[lukas-w]

I don't really understand why b2a30c2 works, but the rest looks good to me 👍

[PhysSong]

Merge?

[jasp00]

I do not look at requests that fix more than one issue. Changes have been approved, so merge at your discretion.

[DomClark]

I don't really understand why b2a30c2 works, but the rest looks good to me 👍

@lukas-w It ensures the owner change is done before the window is shown. Why that is necessary I'm not sure, but it seems to work. I guess it might just be some quirk of Windows.

Merge?

@PhysSong I haven't been able to test 510d0b9 because I'm having some issues building on Linux, so I'd like to get that done first. Would you be able to provide an AppImage?

I do not look at requests that fix more than one issue.

@jasp00 The fixes have been split into separate commits. I'm not sure how splitting them into separate PRs affects reviewability, other than that you can't approve them independently. If you don't want to review, that's fine, since others have approved the changes as you stated. If you do want to review, and you have objections, feel free to reject all the changes and I will happily address any concerns.

[PhysSong]

@PhysSong I haven't been able to test 510d0b9 because I'm having some issues building on Linux, so I'd like to get that done first. Would you be able to provide an AppImage?

I can, but it may take a day.

[PhysSong]

@DomClark https://github.com/PhysSong/lmms/releases/download/vdummy/lmms-1.2.0-rc8.21-linux-x86_64.AppImage

[DomClark]

Thanks for the AppImage @PhysSong. I've tested 510d0b9 and it seems to work, so I'd say this is good to merge now.