Skip to content

Fixes multiple bugs related to BBEditor and time signatures#6096

Open
sdasda7777 wants to merge 2 commits into
LMMS:masterfrom
sdasda7777:BBEditorTimeSigFix2
Open

Fixes multiple bugs related to BBEditor and time signatures#6096
sdasda7777 wants to merge 2 commits into
LMMS:masterfrom
sdasda7777:BBEditorTimeSigFix2

Conversation

@sdasda7777

@sdasda7777 sdasda7777 commented Jul 17, 2021

Copy link
Copy Markdown

This pull request fixes multiple bugs related to BBEditor and time signatures, stemming from incorrect or outdated usage of method getBar():

  • Lines 212 and 228: Fix the issue of incorrect BB track being displayed when time signature is not n/n (Changing time signature causes incorrect BB track to be displayed in the BBEditor #6079)
  • Line 575: Fixes the issue that if new BB subtrack is added when time signature isn't n/n, due to the way getBar() works the result wouldn't be the one the formula using it was hoping for, and, for example, subtrack added at time signature 8/4 would only appear on every other BB track (subtrack for track 1 would appear on track 2, for 2 on 4, etc.).

@LmmsBot

LmmsBot commented Jul 17, 2021

Copy link
Copy Markdown
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/bbe1645b-f462-4adf-9b93-7e1bb2e71891/artifacts/0/lmms-1.3.0-alpha.1.160+ge5b900752-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17609?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/6bbbc35a-a91e-4dad-a80b-fdac4660be08/artifacts/0/lmms-1.3.0-alpha.1.160+ge5b900752-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17607?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://output.circle-artifacts.com/output/job/949cbbbe-c60a-4900-bc3f-3d51a2df766f/artifacts/0/lmms-1.3.0-alpha.1.160+ge5b900752-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17608?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "66d2886be1d878f0bc1c1b39141573832b1e4f7c"}

@PhysSong PhysSong self-requested a review July 22, 2021 02:12
@sdasda7777 sdasda7777 changed the title Fixes BB subtracks being displayed incorrectly if added at non-n/n time signature Fixes multiple bugs related to BBEditor and time signatures Jul 23, 2021
@PhysSong

Copy link
Copy Markdown
Member

It seems like Track::createTCOsForBB needs modification as well to make the behavior consistent.

@sdasda7777

Copy link
Copy Markdown
Author

You're right, that seems to do the trick

Comment thread src/gui/widgets/TrackContentWidget.cpp Outdated
@sdasda7777 sdasda7777 force-pushed the BBEditorTimeSigFix2 branch from ac9cf2e to 66d2886 Compare June 28, 2022 11:16
@tresf tresf added rework required Pull requests which must be reworked to make it able to merge or review and removed after-refactor labels Mar 2, 2025
@messmerd messmerd added the bug label May 2, 2026
@rubiefawn rubiefawn force-pushed the BBEditorTimeSigFix2 branch from 66d2886 to 3f0c3ba Compare July 2, 2026 06:17
@rubiefawn

Copy link
Copy Markdown
Contributor

I fixed the comically absurd diff† by cherry-picking‡ the two commits that actually matter for this PR onto current master branch.

image image

‡ Rewrote the equivalent, since files and classes have all been renamed since the original commits were made lol

@rubiefawn rubiefawn added needs code review A functional code review is currently required for this PR needs testing This pull request needs more testing and removed rework required Pull requests which must be reworked to make it able to merge or review labels Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug needs code review A functional code review is currently required for this PR needs testing This pull request needs more testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants