min/max Bass & Treble sliders in Player's setting are hardcoded

[philippe44]

Players can define their Min and Max for Bass/Treble through minTreble/MaxTreble (See Player::Boom.pm)... These values are passed to the Player settings menu in Buttons::Settings. But in player.html, the sliders are hardcoded -23 to 23. This is the part of LMS / Perl ToolKit that I know the least so I'm not sure how to change that so that min/max values are honored

[mherger]

Would the following do it?

diff --git a/HTML/EN/settings/player/audio.html b/HTML/EN/settings/player/audio.html
index f8fe4c0a8..a36cbace9 100644
--- a/HTML/EN/settings/player/audio.html
+++ b/HTML/EN/settings/player/audio.html
@@ -151,13 +151,13 @@
 		[% WRAPPER settingSection %]
 			[% IF prefs.exists('pref_bass') %]
 				[% WRAPPER settingGroup title="BASS" desc="" %]
-				<input type="text" class="stdedit sliderInput_-23_23" name="pref_bass" id="pref_bass" value="[% prefs.pref_bass %]" size="5">
+				<input type="text" class="stdedit sliderInput_[% minBass %]_[% maxBass %]" name="pref_bass" id="pref_bass" value="[% prefs.pref_bass %]" size="5">
 				[% END %]
 			[% END %]
 
 			[% IF prefs.exists('pref_treble') %]
 				[% WRAPPER settingGroup title="TREBLE" desc="" %]
-				<input type="text" class="stdedit sliderInput_-23_23" name="pref_treble" id="pref_treble" value="[% prefs.pref_treble %]" size="5">
+				<input type="text" class="stdedit sliderInput_[% minTreble %]_[% maxTreble %]" name="pref_treble" id="pref_treble" value="[% prefs.pref_treble %]" size="5">
 				[% END %]
 			[% END %]
 
diff --git a/Slim/Web/Settings/Player/Audio.pm b/Slim/Web/Settings/Player/Audio.pm
index accacd9e2..11f658c64 100644
--- a/Slim/Web/Settings/Player/Audio.pm
+++ b/Slim/Web/Settings/Player/Audio.pm
@@ -127,6 +127,11 @@ sub beforeRender {
 		$paramRef->{'allowNoLimit'} = 1;
 	}
 
+	$paramRef->{'maxTreble'} = $client->maxTreble;
+	$paramRef->{'minTreble'} = $client->minTreble;
+	$paramRef->{'maxBass'}   = $client->maxBass;
+	$paramRef->{'minBass'}   = $client->minBass;
+
 	$paramRef->{'prefs'}->{pref_maxBitrate} = Slim::Utils::Prefs::maxRate($client, 1);
 }
 

[philippe44]

Yes, it seems perfect - I'm sorry I'm always struggling with this part of LMS/PerlTemplateToolKit. I never know what should be variable, what can be called as a function in the HTML part

[mherger]

I'm happy to fix these simple issues, while you take care of the streaming issues!