only use synchronized volume players#203
Merged
mherger merged 1 commit intoLMS-Community:public/7.9from Nov 5, 2018
philippe44:syncVolume
Merged
only use synchronized volume players#203mherger merged 1 commit intoLMS-Community:public/7.9from philippe44:syncVolume
mherger merged 1 commit intoLMS-Community:public/7.9from
philippe44:syncVolume
Conversation
Contributor
Author
|
While discussing the HTTP keep-alive, I was reviewing my past submissions. Was this one wrong? Shall I remove it? |
Contributor
|
I'm sorry, never really looked into this one. What behaviour does it "fix"? |
Contributor
|
Never mind... read up on the bug report and forum thread. Thanks! |
Contributor
Author
|
Thanks - I hope I did not do anything silly. Obviously I have a poor track record in the quality of my submissions |
Contributor
|
No worries: the reviewer obviously didn't know better :-D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize volume only amongst players which have the sync volume attribute set, including at stream startup (i.e. the sync master is not always used as the reference volume)