Skip to content

Change to detect MPEG-4 files with leading mdat. These files have the…#270

Merged
mherger merged 2 commits intoLMS-Community:public/7.9from
bpa-code:public/7.9
Jul 24, 2019
Merged

Change to detect MPEG-4 files with leading mdat. These files have the…#270
mherger merged 2 commits intoLMS-Community:public/7.9from
bpa-code:public/7.9

Conversation

@bpa-code
Copy link
Copy Markdown
Contributor

… audio index at the

end of the file and so cannot be played streaming. Player with native AAC/ALAC such as
Radio, Touch, squeezelite when trying to play these file will log LMS error
"Decoder does not support file format, code 0".
This change creates new audio types alcx and mp4x for these files and so will always
be transcoded. The new types appear in FileTypes settings as "MP-4 leading mdat"
"Apple Lossless leading mdat"

Users can "fix" these files by using ffmpeg "movflags +faststart" option.

… audio index at the

end of the file and so cannot be played streaming. Player with native AAC/ALAC such as
Radio, Touch, squeezelite when trying to play these file will log LMS error
"Decoder does not support file format, code 0".
This change creates new audio types alcx and mp4x for these files and so will always
be transcoded. The new types appear in FileTypes settings as "MP-4 leading mdat"
"Apple Lossless leading mdat"

Users can "fix" these files by using ffmpeg "movflags +faststart" option.
@michaelherger
Copy link
Copy Markdown
Member

I'll give this a try asap. As I had to look up what "mdat" was standing for, I'd like to ask you to change the string to "metadata" instead?

@bpa-code
Copy link
Copy Markdown
Contributor Author

bpa-code commented Jul 21, 2019

I presume this is the text that appears in "FileTypes". I know text is not great but I felt something is added to indicate the difference.
mdat does not mean metadata - it is the MPEG-4 term for the atom "media data" - it is the audio data - the problem is the "audio" is in front of the index into the audio

so perhaps in FileTypes - "trailing metadata" or "leading audio" rather than "leading mdat"

@mherger mherger merged commit 2433703 into LMS-Community:public/7.9 Jul 24, 2019
@mherger
Copy link
Copy Markdown
Contributor

mherger commented Jul 24, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants