Change to detect MPEG-4 files with leading mdat. These files have the…#270
Merged
mherger merged 2 commits intoLMS-Community:public/7.9from Jul 24, 2019
bpa-code:public/7.9
Merged
Change to detect MPEG-4 files with leading mdat. These files have the…#270mherger merged 2 commits intoLMS-Community:public/7.9from bpa-code:public/7.9
mherger merged 2 commits intoLMS-Community:public/7.9from
bpa-code:public/7.9
Conversation
… audio index at the end of the file and so cannot be played streaming. Player with native AAC/ALAC such as Radio, Touch, squeezelite when trying to play these file will log LMS error "Decoder does not support file format, code 0". This change creates new audio types alcx and mp4x for these files and so will always be transcoded. The new types appear in FileTypes settings as "MP-4 leading mdat" "Apple Lossless leading mdat" Users can "fix" these files by using ffmpeg "movflags +faststart" option.
Member
|
I'll give this a try asap. As I had to look up what "mdat" was standing for, I'd like to ask you to change the string to "metadata" instead? |
Contributor
Author
|
I presume this is the text that appears in "FileTypes". I know text is not great but I felt something is added to indicate the difference. so perhaps in FileTypes - "trailing metadata" or "leading audio" rather than "leading mdat" |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… audio index at the
end of the file and so cannot be played streaming. Player with native AAC/ALAC such as
Radio, Touch, squeezelite when trying to play these file will log LMS error
"Decoder does not support file format, code 0".
This change creates new audio types alcx and mp4x for these files and so will always
be transcoded. The new types appear in FileTypes settings as "MP-4 leading mdat"
"Apple Lossless leading mdat"
Users can "fix" these files by using ffmpeg "movflags +faststart" option.