refactor: extract Timer and Meta into isolated classes#57
Merged
Conversation
Move the timer store/elapsed logic into HellogTimer (lib/timer.ts) and meta resolution/merging into HellogMeta (lib/meta.ts). Hellog now delegates to both; public behavior (child meta merging, timer durations) is unchanged. Closes #56. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #55. Extracts the timer and meta responsibilities out of the growing
Hellogclass into dedicated classes that own their logic and serialization, per the review note on #55.lib/timer.ts→HellogTimer— owns theMap<string, bigint>timer store,start(label),end(label): number | undefined(one-shot), and a staticformat(label, ms)for duration serialization.lib/meta.ts→HellogMeta— owns meta resolution and parent/child merging viaresolve(),merge(extra),child(extra), replacingHellog._resolveMetaand the inline merge logic inchild/_log.Hellognow delegates to both. Public behavior (child meta merging, dynamic meta, timer durations,durationMs) is unchanged.lib/index.ts; addedlib/timer.spec.tsandlib/meta.spec.ts.Closes #56.
Notes
Test plan
npm run build— clean under@tsconfig/strictestnpm test— 45/45 pass (32 existing + 13 new timer/meta specs)npm run lint— oxlint cleannpm run format:check— oxfmt clean🤖 Generated with Claude Code