fix(service): correct notification throttle logic in ServiceManager.setMeta - #1873
Merged
rajarsheechatterjee merged 1 commit intoJul 1, 2026
Conversation
rajarsheechatterjee
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the notification throttle in
ServiceManager.setMeta(if condition branch). Two bugs turned it into a no-op:Root Cause
setTimeoutinstead of firing right away; the "<1s" path fired right away instead of deferring. The leading and trailing edge logic ran backwards.1000 - now - this.lastNotifUpdatesubtracts two epoch timestamps (results in negative values) instead of1000 - (now - this lastNotifUpdate), sosetTimeoutfired on the next tick every time.Net effect:
BackgroundService.updateNotificationran on everysetMetacall, once per novel during a library update, so 30-100 notification updates per sweep.Change Made
At
src/services/ServiceManager.ts [lines 152-153], flipped the throttle condition and fixed the delay arithmetic.