Skip to content

fix(ci): generate stable updater download URLs#16

Merged
LRainner merged 1 commit into
masterfrom
codex/fix-updater-download-urls
Jul 27, 2026
Merged

fix(ci): generate stable updater download URLs#16
LRainner merged 1 commit into
masterfrom
codex/fix-updater-download-urls

Conversation

@LRainner

@LRainner LRainner commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • generate updater asset URLs from the repository, final release tag, and asset name
  • prevent draft-only untagged URLs from being stored in latest.json
  • keep the change scoped to the updater manifest generator

Root cause

The atomic release workflow generates latest.json while the GitHub Release is still a draft. At that point, GitHub reports browser download URLs under a temporary releases/download/untagged-* path.

Those temporary URLs stop working after the release is published. The v1.2.3 manifest therefore kept three stale URLs that returned 404, even though the same assets were available under releases/download/v1.2.3.

Fix

The manifest generator now builds public asset URLs from the repository name, release.tag_name, and encoded asset name. Signature files are still downloaded through the authenticated Release Asset API while the release is a draft.

This preserves the atomic draft workflow while ensuring the published manifest contains stable URLs.

Verification

  • node --check scripts/generate-updater-manifest.mjs
  • git diff --check
  • generated a manifest against Release ID 360061533 for v1.2.3
  • confirmed all three old untagged URLs returned 404
  • confirmed the generated macOS ARM, macOS x86, and Windows URLs return 200

Release handling

The broken latest.json asset on the published v1.2.3 Release was replaced separately with a corrected manifest. All three public updater asset URLs now return 200. This PR prevents the same issue in future releases.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed updater download links for macOS and Windows releases.
    • Downloads now consistently point to the correct release assets, improving update reliability across supported platforms.
    • Existing platform signature verification remains unchanged.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 68c4d6b8-65d1-49cb-b9ce-2be79a984af2

📥 Commits

Reviewing files that changed from the base of the PR and between 42af82f and 18252b5.

📒 Files selected for processing (1)
  • scripts/generate-updater-manifest.mjs

📝 Walkthrough

Walkthrough

The updater manifest generator now constructs macOS and Windows download URLs from the repository, release tag, and asset name instead of using asset-provided browser URLs. Signature fields remain unchanged.

Changes

Updater manifest

Layer / File(s) Summary
Construct release asset URLs
scripts/generate-updater-manifest.mjs
Adds a downloadUrl(asset) helper and uses it for macOS and Windows platform URLs while retaining the existing signature values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: generating stable updater download URLs in CI-related manifest generation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@LRainner
LRainner merged commit e08322f into master Jul 27, 2026
8 checks passed
@LRainner
LRainner deleted the codex/fix-updater-download-urls branch July 27, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant