fix(ci): generate stable updater download URLs#16
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe updater manifest generator now constructs macOS and Windows download URLs from the repository, release tag, and asset name instead of using asset-provided browser URLs. Signature fields remain unchanged. ChangesUpdater manifest
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The atomic release workflow generates latest.json while the GitHub Release is still a draft. At that point, GitHub reports browser download URLs under a temporary releases/download/untagged-* path.
Those temporary URLs stop working after the release is published. The v1.2.3 manifest therefore kept three stale URLs that returned 404, even though the same assets were available under releases/download/v1.2.3.
Fix
The manifest generator now builds public asset URLs from the repository name, release.tag_name, and encoded asset name. Signature files are still downloaded through the authenticated Release Asset API while the release is a draft.
This preserves the atomic draft workflow while ensuring the published manifest contains stable URLs.
Verification
Release handling
The broken latest.json asset on the published v1.2.3 Release was replaced separately with a corrected manifest. All three public updater asset URLs now return 200. This PR prevents the same issue in future releases.
Summary by CodeRabbit