Skip to content

Conversation

@TommoLeedsy
Copy link
Contributor

This PR adds lint and test jobs to the CI pipeline

@Will-Mann-16
Copy link
Contributor

Is this needed as the purpose of the CI was to publish the next version (tag it) so what happens if it fails?

@TommoLeedsy
Copy link
Contributor Author

TommoLeedsy commented Jan 21, 2024

I think this is very useful to test the code one its in main, its standard practice, also at the moment the CI is setup so that the release job will run independently of the lint and test jobs but there is something to be said for this not to be the case as it would mean that we don't tag releases with falling tests? Moving to that setup where release depends on the other jobs in the pipeline passing would also mirror how we have it setup in astra.

@Will-Mann-16 Will-Mann-16 merged commit 1f1fc4c into main Jan 21, 2024
@Will-Mann-16 Will-Mann-16 deleted the chore/improve-ci-pipeline branch January 21, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants