Skip to content

fix: lint issues#125

Merged
maneeshaxyz merged 1 commit intomainfrom
117-bug-fix-the-golangci-lint-issues
Nov 20, 2025
Merged

fix: lint issues#125
maneeshaxyz merged 1 commit intomainfrom
117-bug-fix-the-golangci-lint-issues

Conversation

@Aravinda-HWK
Copy link
Copy Markdown
Collaborator

📌 Description

This PR is to resolve the lint issues in the Raven repo.


🔍 Changes Made

  • 50 errcheck issues - Added proper error handling using _ = or defer func() { _ = ... }() patterns
  • 1 ineffassign issue - Removed ineffectual assignment in internal/delivery/parser/parser.go
  • 5 staticcheck issues - Fixed deprecated io/ioutil import, error message formatting, and redundant code
  • 2 unused warnings - Removed unused functions (parseUIDSequenceSet and ensureDefaultMailboxes)

✅ Checklist (Email System)

  • Core IMAP commands tested (LOGIN, CAPABILITY, LIST, SELECT, FETCH, LOGOUT).
  • Authentication is tested.
  • Docker build & run validated.
  • Configuration loading verified for default and custom paths.
  • Persistent storage with Docker volume verified.
  • Error handling and logging verified
  • Documentation updated (README, config samples).

🧪 Testing Instructions

To test the server, use the instructions in the README in the test directory.


📷 Screenshots / Logs (if applicable)


⚠️ Notes for Reviewers

@Aravinda-HWK Aravinda-HWK self-assigned this Nov 20, 2025
@Aravinda-HWK Aravinda-HWK linked an issue Nov 20, 2025 that may be closed by this pull request
@maneeshaxyz maneeshaxyz merged commit 4db08be into main Nov 20, 2025
4 checks passed
@Aravinda-HWK Aravinda-HWK deleted the 117-bug-fix-the-golangci-lint-issues branch November 20, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix the golangci-lint issues

2 participants