Skip to content

feat: add Grafana domain update functionality in gen-observability script#275

Merged
Aravinda-HWK merged 2 commits intoLSFLK:mainfrom
Aravinda-HWK:274-feature-add-grafanaini-update-script-to-change-the-domain
Feb 26, 2026
Merged

feat: add Grafana domain update functionality in gen-observability script#275
Aravinda-HWK merged 2 commits intoLSFLK:mainfrom
Aravinda-HWK:274-feature-add-grafanaini-update-script-to-change-the-domain

Conversation

@Aravinda-HWK
Copy link
Copy Markdown
Collaborator

📌 Description

Add a code section to update the <MAIL_DOMAIN> value in the grafana.ini configuration file coming from the silver-config.


🔍 Changes Made

  • Update the gen-observability.sh to update grafana.ini file

✅ Checklist (Email System)

  • Core services tested (SMTP, IMAP, mail storage, end-to-end delivery)
  • Security & compliance verified (auth via Thunder IDP, TLS, DKIM/SPF/DMARC, spam/virus filtering)
  • Configuration & deployment checked (configs generated, Docker/Compose updated)
  • Reliability confirmed (error handling, logging, monitoring)
  • Documentation & usage notes updated (README, deployment, API)

🧪 Testing Instructions


📷 Screenshots / Logs (if applicable)


⚠️ Notes for Reviewers

@Aravinda-HWK Aravinda-HWK self-assigned this Feb 26, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Aravinda-HWK, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the gen-observability.sh script by introducing an automated mechanism to configure Grafana. It ensures that the Grafana configuration file (grafana.ini) correctly reflects the system's mail domain, streamlining the setup process and preventing manual configuration errors related to domain settings.

Highlights

  • Grafana Domain Update: Added functionality to the gen-observability.sh script to automatically update the <MAIL_DOMAIN> placeholder in the grafana.ini configuration file with the actual MAIL_DOMAIN value, ensuring correct domain configuration for Grafana.
Changelog
  • services/config-scripts/gen-observability.sh
    • Defined a new variable GRAFANA_CONFIG_FILE to specify the path to grafana.ini.
    • Implemented a new section to update the Grafana domain in grafana.ini by replacing a placeholder with the actual MAIL_DOMAIN.
    • Added error handling to check for the existence of the grafana.ini file before modification.
    • Adjusted file ownership for the modified grafana.ini.
Activity
  • No human activity on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds functionality to the gen-observability.sh script to update the domain in the grafana.ini configuration file. The changes are logical and follow the existing script's structure. The identified potential issue regarding silent failure if no domain is configured is valid and the suggested check improves robustness.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Member

@maneeshaxyz maneeshaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Aravinda-HWK Aravinda-HWK merged commit 5006a0b into LSFLK:main Feb 26, 2026
6 checks passed
@Aravinda-HWK Aravinda-HWK deleted the 274-feature-add-grafanaini-update-script-to-change-the-domain branch February 26, 2026 04:44
Aravinda-HWK added a commit to Aravinda-HWK/silver that referenced this pull request Mar 17, 2026
…ript (LSFLK#275)

* feat: add Grafana domain update functionality in gen-observability script

* Update services/config-scripts/gen-observability.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add grafana.ini update script to change the domain

2 participants