docs: remove unused conf/users.yaml and update Adding users to Thunder flow (#338)#339
Merged
Aravinda-HWK merged 4 commits intoMay 23, 2026
Merged
Conversation
Closes LSFLK#338 - Delete conf/users.yaml (no script or service reads it; companion scripts/user/add_user.sh was removed in an earlier cleanup). - Rewrite the "Adding users" section of README.md to describe the actual provisioning paths: the Thunder console UI and the Thunder /users REST API, with a curl example and pointers to scripts/user/create_test_users.sh and the Thunder API consumer guide.
Closed
3 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the user provisioning process by replacing the manual configuration in users.yaml with an integration with Thunder, an identity provider. The README.md has been updated to include instructions for provisioning users via the Thunder Console and REST API, and the deprecated conf/users.yaml file has been removed. Feedback was provided to include the default admin credentials in the documentation to assist users during the initial setup.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Aravinda-HWK
requested changes
May 23, 2026
…to docs/ Per reviewer feedback on LSFLK#339: - Drop the Thunder /users API option from the README; keep the section to a single short paragraph pointing at the Thunder ID console. - Move the full walkthrough (admin login, user schema creation, OU assignment, direct-password vs invitation-link) into a new docs/Adding-Users.md so the README stays concise. - Update Thunder repo link to its new home at thunder-id/thunderid (both in the Adding users section and Open Source Components list). - Drop the "(default is admin/admin)" hint per reviewer — admins rotate the credentials and the README should not imply defaults.
Aravinda-HWK
requested changes
May 23, 2026
…tion - Append /console to the Thunder console URL in README and docs. - Drop the "silver" organization unit name (varies by deployment). - Remove the programmatic-provisioning section; the example script is outdated and out of scope for this docs PR.
Collaborator
|
@prdai Thanks for the contribution and we hope your contribution in future as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #338.
conf/users.yaml— no script, compose file, or service reads it, and the companionscripts/user/add_user.shwas removed in an earlier cleanup.README.mdto describe the actual Thunder-based provisioning flow: the Thunder console UI athttps://<your-domain>:8090, and the Thunder/usersREST API with a curl example.scripts/utils/thunder-auth.sh,scripts/user/create_test_users.sh, anddocs/Thunder-API-Consumer-Contract-Guide-for-Silver.mdfor the auth flow and a working bulk example.Note: AI assistance used for grep-based reference discovery and drafting the new README section.