Correct normalization in photon diffraction by circles#507
Merged
Conversation
… in directed_dist().
…om the disk of diffacted photons.
…tion for better average calculation when disk diffracted photons are mixed in.
rmjarvis
approved these changes
Feb 6, 2026
Contributor
rmjarvis
left a comment
rmjarvis
left a comment
There was a problem hiding this comment.
LGTM. Thanks for finding this bug, William.
Collaborator
Author
|
My last PR should have fixed CI, so I'm going ahead and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address #506. I've made the fix to the normalization that I suggested in that issue and also made changes to the two tests it caused to fail. Those failures are because we now see a lot of photons making up a disk around the test star, whereas before they were pure spikes. Some of the numbers I picked in
test_rubin_diffraction_produces_spikes()feel a little arbitrary to me, so please let me know if they could be made more physical.