Skip to content

Fix rail_lephare smoke test#199

Merged
sschmidt23 merged 1 commit intomainfrom
tqz/fix_smoke_test
Jun 2, 2025
Merged

Fix rail_lephare smoke test#199
sschmidt23 merged 1 commit intomainfrom
tqz/fix_smoke_test

Conversation

@ztq1996
Copy link
Copy Markdown
Contributor

@ztq1996 ztq1996 commented Jun 2, 2025

Problem & Solution Description (including issue #)

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (5203be5) to head (02ee880).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          47       47           
  Lines        3231     3231           
=======================================
  Hits         3223     3223           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@sschmidt23 sschmidt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a notebook is failing the smoke test because it isn't properly finding the para file, this and #188 from RAIL look to fix that, approved.

@sschmidt23 sschmidt23 merged commit f56848f into main Jun 2, 2025
7 checks passed
@eacharles eacharles deleted the tqz/fix_smoke_test branch July 31, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants