System.InvalidOperationException thrown when `Stop()` is called during web playback

[markjamesm]

When attempting to call the Stop() method while a web stream is playing, an exception is thrown:

Unhandled exception. System.InvalidOperationException: Seeking is not supported for this sound.

Stack Trace

Playing stream... Press any key to stop.
Unhandled exception. System.InvalidOperationException: Seeking is not supported for this sound.
   at SoundFlow.Components.SoundPlayer.Seek(Int32 sampleOffset)
   at SoundFlow.Components.SoundPlayer.Stop()
   at WebPlayback.Program.Main(String[] args) in /SoundFlow Test/QuickTest/Program.cs:line 36
   at WebPlayback.Program.<Main>(String[] args)

Minimum reproducible example

• Use the web playback example from the SoundFlow documentation.
• Replace your-audio-stream-url with http://ice6.somafm.com/sonicuniverse-128-mp3 (Soma.fm online radio stream)
• Run the code, and once you press a key to stop the stream, the exception will throw.

[markjamesm]

Upon further investigation, there's a call to Seek() within the Stop() method of SoundPlayer.cs which sets the playback position to 0. Given that web streams don't have a start time, this throws the InvalidOperationException contained within the Seek() method.

Adding a check within the Stop() method to see if the DataProvider can seek appears to resolve the issue. Moreover, I added some code so that if the provider can't seek, then a proper stop state is created:

public void Stop()
{
    if (dataProvider.CanSeek)
    {
        Pause();
        Seek(0);
    }

    Enabled = false;
    State = PlaybackState.Stopped;
}

I've tested this on my end and the bug is resolved using the code above. I've submitted a PR with the proposed fix implemented.

[LSXPrime]

Thank you for your report. I apologize for closing your PR. I have modified the seeking mechanism to return a boolean value instead of throwing exceptions, thereby reducing the use of try-catch blocks and minimizing unnecessary overhead. You shouldn't encounter this issue now if you use library from source.

[LSXPrime]

The updated Seek mechanism available in latest update (v1.0.4). Please update the SoundFlow package from NuGet.