Cleaned dead/debug code in X86BinaryAssembler, all tests pass#427
Open
opencode-agent[bot] wants to merge 1 commit into
Open
Cleaned dead/debug code in X86BinaryAssembler, all tests pass#427opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
Co-authored-by: LSantha <LSantha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review of
X86BinaryAssembler.javahas been completed with the following fixes applied:Changes Made:
Line 627 - Removed debug
System.out.printlnstatement ingetUnresolvedObjectRefs()Lines 2271-2276 - Simplified redundant exception handling in
writeJECXZ():IllegalArgumentExceptionbut caughtUnresolvedObjectRefException(which was never thrown), resulting in unreachable catch blockIllegalArgumentExceptionLines 2458-2517 - Cleaned up dead code in
writeLEA()method:if (true)block with internal comments indicating incomplete refactoring&& falseconditionswriteModRMRREXPrefix,write8)Build Status:
BUILD SUCCESSFUL- All tests pass after changes.Closes #417
opencode session | github run