Skip to content

Fixed 2 bugs in XMLElement.java#428

Open
LSantha wants to merge 1 commit into
masterfrom
opencode/issue418-20260517152007
Open

Fixed 2 bugs in XMLElement.java#428
LSantha wants to merge 1 commit into
masterfrom
opencode/issue418-20260517152007

Conversation

@LSantha
Copy link
Copy Markdown
Owner

@LSantha LSantha commented May 17, 2026

Fixed 2 critical bugs:

  1. Missing break statement (line 2304): Added missing break after in the
    ο node/20.20.2

Use up/down arrow keys to select a version, return key to install, d to delete, q to quit copying : node/20.20.2
installed : v20.20.2 (with npm 10.8.2) case to prevent fallthrough to case
2. Swallowed IOException (lines 1716, 1824): Replaced comment with to fail fast if assumptions change

Closes #418

- Added missing break statement in scanWhitespace (line 2304) to prevent
  fallthrough from \n case to \r case
- Replaced swallowed IOException with AssertionError in parseString methods
  (lines 1716, 1824) - fails fast if assumptions change
@opencode-agent opencode-agent Bot mentioned this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review XMLElement.java

1 participant