fix takes_imported never logged from TakesImportModal#166
Merged
mfwolffe merged 1 commit intoLab-Lab-Lab:mainfrom Apr 3, 2026
Merged
fix takes_imported never logged from TakesImportModal#166mfwolffe merged 1 commit intoLab-Lab-Lab:mainfrom
mfwolffe merged 1 commit intoLab-Lab-Lab:mainfrom
Conversation
TakesImportModal bypasses handleImportTake entirely — it calls addTrack directly via context. The onImport prop was passed but never used, so takes_imported was never logged. Removed the dead onImport prop and added logging directly in the modal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TakesImportModalbypasses theonImportcallback entirely — it callsaddTrackdirectly via context, so thetakes_importedoperation was never loggedlogOperation('takes_imported')directly in the modal and removed the deadonImportprop