Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to manually set and expose the commit status by updating the devcontainer hash action and adjusting the CI workflow.
- Added new outputs ("new-sha" and "commit-created") to the update-devcontainer-hash action
- Updated the CI workflow to capture these outputs and, when applicable, update the dependabot status via the GitHub API
- Bumped the copier template commit in .copier-answers.yml
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| template/.github/actions/update-devcontainer-hash/action.yml | Added outputs and updated commit step to propagate the new SHA and commit status |
| .github/workflows/ci.yaml | Modified job outputs and added a step to update the commit status using the GitHub API |
| .copier-answers.yml | Updated the copier template commit reference |
| echo "new-sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "No changes to commit" | ||
| echo "commit-created=false" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Consider outputting a default value for 'new-sha' in the branch where no changes are committed. This would provide a consistent output structure for dependent workflows even when no commit is created.
Suggested change
| echo "commit-created=false" >> $GITHUB_OUTPUT | |
| echo "commit-created=false" >> $GITHUB_OUTPUT | |
| echo "new-sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new tactic