-
Notifications
You must be signed in to change notification settings - Fork 1
Copier update (pre-commit bumps) #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,8 @@ jobs: | |
| with: | ||
| ref: ${{ github.event.pull_request.merge_commit_sha }} | ||
| fetch-depth: '0' | ||
| persist-credentials: false | ||
| - name: Bump version and push tag | ||
| uses: mathieudutour/github-tag-action@v6.2 | ||
| uses: mathieudutour/github-tag-action@a22cf08638b34d5badda920f9daf6e72c477b07b # v6.2 | ||
|
||
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,5 @@ | ||||||||||||||||||||||
| rules: | ||||||||||||||||||||||
| template-injection: | ||||||||||||||||||||||
| ignore: | ||||||||||||||||||||||
| # this is just echo-ing out the github context to be visible for debugging, it's not executing commands | ||||||||||||||||||||||
| - get-values.yaml:28 | ||||||||||||||||||||||
|
Comment on lines
+1
to
+5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tighten ignore path to match the template file precisely. The ignore entry references get-values.yaml:28; the changed file lives under template/.github/workflows. Use the full path to avoid a mis‑match. Apply this diff: - - get-values.yaml:28
+ - template/.github/workflows/get-values.yaml:28📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |||||
| # Usage | ||||||
| To create a new repository using this template: | ||||||
| 1. Create a basic devcontainer either using the Codespaces default or using the file `.devcontainer/devcontainer-to-instantiate-template.json` from [the base template repo](https://github.com/LabAutomationAndScreening/copier-base-template/blob/main/.devcontainer/devcontainer-to-instantiate-template.json) | ||||||
| 1. Inside that devcontainer, run `python .devcontainer/install-ci-tooling.py` to install necessary tooling to instantiate the template (you can copy/paste the script from this | ||||||
| 1. Inside that devcontainer, run `python .devcontainer/install-ci-tooling.py` to install necessary tooling to instantiate the template (you can copy/paste the script from this repo...and you can paste it in the root of the repo if you want) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarify path if script is moved to repo root and tighten wording. Apply this diff: -1. Inside that devcontainer, run `python .devcontainer/install-ci-tooling.py` to install necessary tooling to instantiate the template (you can copy/paste the script from this repo...and you can paste it in the root of the repo if you want)
+1. Inside that devcontainer, run `python .devcontainer/install-ci-tooling.py` to install necessary tooling to instantiate the template. You can copy the script from this repo; if you place it at the repository root, run `python install-ci-tooling.py` instead.📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| 1. Delete all files currently in the repository. Optional...but makes it easiest to avoid git conflicts. | ||||||
| 1. Run copier to instantiate the template: `copier copy --trust gh:LabAutomationAndScreening/copier-python-package-template.git .` | ||||||
| 1. Run `python .devcontainer/manual-setup-deps.py --only-create-lock` to generate the lock file(s) | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,8 +24,13 @@ jobs: | |
| dependabot-commit-created: ${{ steps.update-hash.outputs.commit-created }} | ||
| pr-short-num: ${{ steps.find-pr-num.outputs.number }} | ||
| steps: | ||
| - name: Display full GitHub context | ||
| run: echo '${{ toJSON(github) }}' | ||
|
|
||
|
Comment on lines
+27
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gate the GitHub context dump to avoid noisy logs and potential metadata leakage. Restrict to trusted events or an explicit debug flag. Apply this diff to add a guard on the step: - - name: Display full GitHub context
- run: echo '${{ toJSON(github) }}'
+ - name: Display full GitHub context
+ if: ${{ (github.event_name != 'pull_request' && github.event_name != 'pull_request_target') && (inputs.debug || env.ACTIONS_STEP_DEBUG == 'true') }}
+ run: echo '${{ toJSON(github) }}'And add this input at the top (outside this hunk) so callers can enable when needed: # under on.workflow_call.inputs
debug:
description: 'Enable verbose context logging'
type: boolean
default: false🤖 Prompt for AI Agents |
||
| - name: Checkout code | ||
| uses: actions/checkout@v5.0.0 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Update Devcontainer Hash | ||
| if: ${{ github.actor == 'dependabot[bot]' && github.event_name == 'push' }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote value containing an ampersand to avoid YAML parsing edge cases.
Safer to quote strings with “&” to prevent any anchor parsing quirks.
Apply this diff:
📝 Committable suggestion
🤖 Prompt for AI Agents