Skip to content

Conversation

@RafaelCenzano
Copy link
Member

Add page to list saved opportuntiies

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if a larger change)
  • New and existing unit tests pass locally with my changes

@WBroadwell
Copy link
Contributor

WBroadwell commented Oct 17, 2025

Should
${process.env.REACT_APP_BACKEND_SERVER}/savedOpportunities and
${process.env.REACT_APP_BACKEND_SERVER}/unsaveOpportunity/${opportunity.id}
in Saved.tsx get changed to
${import.meta.env.VITE_BACKEND_SERVER}/savedOpportunities
${import.meta.env.VITE_BACKEND_SERVER}/unsaveOpportunity?

@WBroadwell
Copy link
Contributor

Also, do you think it should stay as its own tab or be reworked under the Opportunities tab next to search? I can handle reworking either Opportunities or Saved either way but we have both rn

@RafaelCenzano
Copy link
Member Author

Also, do you think it should stay as its own tab or be reworked under the Opportunities tab next to search? I can handle reworking either Opportunities or Saved either way but we have both rn

Up to you guys I don't think it makes a huge difference

Copy link
Contributor

@WBroadwell WBroadwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i'll modify it a bit including the backend licks when I PR and rebranch

@WBroadwell WBroadwell merged commit 129f18a into main Oct 17, 2025
5 checks passed
RafaelCenzano added a commit that referenced this pull request Oct 18, 2025
@RafaelCenzano RafaelCenzano deleted the task/52-create-page-to-show-saved-opportunities branch October 18, 2025 00:20
doan-neyugn pushed a commit that referenced this pull request Oct 21, 2025
Saved opportunities page

Reminder for me:
change the routes to vite
combine / get rid of duplicate saved section on Oppotunities page
doan-neyugn pushed a commit that referenced this pull request Oct 23, 2025
…ion/MainNavigation.tsx

Create page to show saved opportunities (#165)

Saved opportunities page

Reminder for me:
change the routes to vite
combine / get rid of duplicate saved section on Oppotunities page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants