Minor auto-refactor code cleanup on a massive scale

[labkey-jeckels]

Rationale

We can cleanup tens of thousands of warnings across our codebase with IntelliJ's autorefactors. In some cases, this adopts newer, leaner syntax. In others, it simply removes code that's not serving any purpose.

Related Pull Requests

• Minor auto-refactor code cleanup on a massive scale platform#6742

Changes

• Auto-refactors
  • Eliminate redundant toString()
  • Eliminate redundant cast
  • Empty JavaDoc annotations
  • Member variable can be final
  • length() and size() -> isEmpty()
  • Add missing @OverRide
  • Class can be static
  • Remove unused imports
  • toArray() passed array length
  • Remove unnecessary semicolon
  • Explicit type syntax can be replaced by <>
  • Redundant access modifiers
  • Remove redundant initializer
  • "".equals() -> isEmpty()
  • StringBuilder can be replaced by String
  • Fix misordered arguments to assertEquals()
  • StringUtils.defaultString() - Objects.toString()
  • Cast can be replaced with pattern variable
  • Collapse identical catch blocks
  • Type may be primitive
• Manual fixups
  • Delete unused GWT code
  • Improve generics
  • new UnexpectedException() -> UnexpectedException.wrap()

[bbimber]

does this need a cast? I can see how an auto-refactor might do that

[labkey-jeckels]

No, it didn't. Removed. If I had applied the auto-refactors in a different order (removing unneeded casts after switching to primitives) this would have gotten cleaned up automatically.