Merge discvr 20.11 to develop #91
Conversation
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
There's a build failure on a CSV reader dependency:
/mnt/teamcity/work/5d8c476e6f48e7d1/server/modules/DiscvrLabKeyModules/singlecell/api-src/org/labkey/api/singlecell/CellHashingService.java:3: error: package au.com.bytecode.opencsv does not exist
import au.com.bytecode.opencsv.CSVReader;
|
@labkey-jeckels got it, thanks. trunk is more strict than 20.11 i suppose. that package is used in singlecell-api and singlecell module. do I need to add apiImplementation and implementation to uild.gradle? implementation "net.sf.opencsv:opencsv:${opencsvVersion}" |
bbimber
force-pushed
the
fb_merge_discvr-20.11
branch
from
12f8fdd to
ed9488a
Compare
|
@labkey-jeckels I checked in the change to add opencsv. i dont see the TeamCity build, but hopefully this works. |
Add dependency to singlecell-api
|
Build looks happy now. Tests are running. https://teamcity.labkey.org/buildConfiguration/bt312/1239189 |
|
@labkey-jeckels yeah, i figured teamcity out. only issue it that we're hitting errors b/c MCC module now depends on EHR and that's not part of the TC build. @labkey-tchad you fixed this on 20.11. is this something we need in distributitons, or on the TeamCity contig? |
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Please hold the merge until the TeamCity configs are happy on develop, but approving to help move things forward when it's ready.
Merge discvr-21.3 to discvr-21.7
No description provided.