Rename module.xml "requiredModule" element to "module" to match clien… #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t library, html view, and module resource XMLs Switch to returning immutable collections from ModuleXml methods. Junit test for module.xml caching.
Collaborator
|
@labkey-adam so you might have seen i did the same thing in #27 here and in the other two BimberLab repos. I missed this when I was refactoring locally. I suggest closing this and using #27, since that has some other small code cleanup. |
Author
|
Okay... will TeamCity pick up #27 with the other PRs (platform, etc.) so we get pre-merge testing? |
Collaborator
|
yes, keeping TeamCity happy was the theory |
labkey-jeckels
approved these changes
Apr 9, 2020
Author
|
Closing in favor of #27 |
bbimber
added a commit
that referenced
this pull request
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t library, html view, and module resource XMLs