Fix flow NPE: No need to use the ExpData to look itself up#909
Merged
labkey-jeckels merged 1 commit intodevelopfrom Jul 26, 2025
Merged
Fix flow NPE: No need to use the ExpData to look itself up#909labkey-jeckels merged 1 commit intodevelopfrom
labkey-jeckels merged 1 commit intodevelopfrom
Conversation
XingY
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
NPE during the crawler:
https://teamcity.labkey.org/buildConfiguration/LabkeyTrunk_DailyCSqlserver2014/3595782?buildTab=tests&status=failed&name=flow.FlowAnalysisResolverTest&expandedTest=build%3A%28id%3A3595782%29%2Cid%3A2000000139&logFilter=debug&logView=flowAware
Changes
ExpDatawe already have instead of looking up another one (may get a constraint violation when inserting, but at least a small optimization)