Skip to content

add provision for container path option in tsvImport during UpgradeCode#645

Merged
ankurjuneja merged 3 commits intorelease23.7-SNAPSHOTfrom
23.7_fb_544
Aug 24, 2023
Merged

add provision for container path option in tsvImport during UpgradeCode#645
ankurjuneja merged 3 commits intorelease23.7-SNAPSHOTfrom
23.7_fb_544

Conversation

@ankurjuneja
Copy link
Copy Markdown
Contributor

Rationale

This PR adds provision for specifying container path in sql upgrade script when using tsvImport java based upgrade code on module startup.

Related Pull Requests

Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small requests.

Comment thread ehr/api-src/org/labkey/api/ehr/SharedEHRUpgradeCode.java Outdated
}
else
{
importFile(tsvImport, container, user);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's log that we couldn't find the target container and are falling back to the default.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread ehr/api-src/org/labkey/api/ehr/SharedEHRUpgradeCode.java Outdated
ankurjuneja and others added 2 commits August 23, 2023 15:03
@ankurjuneja ankurjuneja merged commit fa22c2c into release23.7-SNAPSHOT Aug 24, 2023
@ankurjuneja ankurjuneja deleted the 23.7_fb_544 branch August 24, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants