Avoid problem from AntBuilder trying to resolve the tomcatJars configuration during pickMssql#100
Merged
Merged
Conversation
labkey-tchad
approved these changes
Nov 5, 2020
This was referenced Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We resolve the tomcatJars files outside of the ant copy because this seems to avoid an error we saw on TeamCity when running the pickMssql task on Windows when updating to Gradle 6.7. The error in the build log was:
The theory is that when the files in the configuration have not been resolved, they get resolved inside the node being added to the ant task below and that is not supported.
Related Pull Requests
Changes