Skip to content

Issue 52979: App grid customize view doesn't expand lookup field with special char#1785

Merged
cnathe merged 10 commits intodevelopfrom
fb_cory256pri3
May 2, 2025
Merged

Issue 52979: App grid customize view doesn't expand lookup field with special char#1785
cnathe merged 10 commits intodevelopfrom
fb_cory256pri3

Conversation

@cnathe
Copy link
Copy Markdown
Contributor

@cnathe cnathe commented May 1, 2025

Rationale

Issue 52979: App grid customize view doesn't expand lookup field with special char

Issue 52472: Re-clicking the Source Types, Sample Types or Assay links in the mega menu removes the sort=Name parameter from the url

Related Pull Requests

Changes

  • use fieldkey for getQueryDetails on customize view modal expand (and related test fixes to use fieldkey)
  • include filters in menu header click

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses two issues: it fixes the lookup field expansion in the App grid customize view (Issue 52979) and retains the sort=Name parameter in the mega menu URL for Source Types, Sample Types, and Assay links (Issue 52472).

  • Replaces the use of column.index with column.fieldKeyPath (and column.fieldKey for comparison) in the customize view modal to correctly handle special characters.
  • Adds a new headerURLParams property in menu configurations and updates menu components to utilize it.
  • Updates ColumnSelectionModal to reflect the new field key encoding in its data attributes and key generation.

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/components/src/public/QueryModel/CustomizeGridViewModal.tsx Switches from using column.index to column.fieldKeyPath/fieldKey to support encoded lookup field values.
packages/components/src/internal/components/navigation/model.ts Introduces headerURLParams to MenuSectionConfig for URL parameter inclusion.
packages/components/src/internal/components/navigation/ProductMenuSection.tsx Adjusts header link generation to use the new headerURLParams.
packages/components/src/internal/components/ColumnSelectionModal.tsx Updates key and data-fieldkey attributes to use the encoded fieldKey values.
packages/components/src/internal/app/utils.ts Adds headerURLParams to various menu configuration functions for preserving sort parameters.
packages/components/releaseNotes/components.md Documents the fixes for Issue 52979 and Issue 52472 in the release notes.
Files not reviewed (2)
  • packages/components/package-lock.json: Language not supported
  • packages/components/package.json: Language not supported
Comments suppressed due to low confidence (2)

packages/components/src/public/QueryModel/CustomizeGridViewModal.tsx:37

  • Verify that replacing column.index with column.fieldKeyPath consistently provides the expected encoded value for the lookup field across all usages.
fk: column.fieldKeyPath, // Issue 52979: use encoded fieldKeyPath

packages/components/src/public/QueryModel/CustomizeGridViewModal.tsx:42

  • Confirm that comparing column.fieldKey with QueryColumn.ANCESTORS_PREFIX is appropriate, ensuring the condition aligns with the use of fieldKeyPath for lookup expansion.
if (column.fieldKey === QueryColumn.ANCESTORS_PREFIX && queryInfo.schemaQuery.schemaName === SCHEMAS.DATA_CLASSES.SCHEMA) {

cnathe added 4 commits May 2, 2025 14:45
# Conflicts:
#	packages/components/package-lock.json
#	packages/components/package.json
#	packages/components/releaseNotes/components.md
@cnathe cnathe merged commit 869f94f into develop May 2, 2025
1 check passed
@cnathe cnathe deleted the fb_cory256pri3 branch May 2, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants