Issue 52979: App grid customize view doesn't expand lookup field with special char#1785
Merged
Issue 52979: App grid customize view doesn't expand lookup field with special char#1785
Conversation
…s in the mega menu removes the sort=Name parameter from the url
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two issues: it fixes the lookup field expansion in the App grid customize view (Issue 52979) and retains the sort=Name parameter in the mega menu URL for Source Types, Sample Types, and Assay links (Issue 52472).
- Replaces the use of column.index with column.fieldKeyPath (and column.fieldKey for comparison) in the customize view modal to correctly handle special characters.
- Adds a new headerURLParams property in menu configurations and updates menu components to utilize it.
- Updates ColumnSelectionModal to reflect the new field key encoding in its data attributes and key generation.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/public/QueryModel/CustomizeGridViewModal.tsx | Switches from using column.index to column.fieldKeyPath/fieldKey to support encoded lookup field values. |
| packages/components/src/internal/components/navigation/model.ts | Introduces headerURLParams to MenuSectionConfig for URL parameter inclusion. |
| packages/components/src/internal/components/navigation/ProductMenuSection.tsx | Adjusts header link generation to use the new headerURLParams. |
| packages/components/src/internal/components/ColumnSelectionModal.tsx | Updates key and data-fieldkey attributes to use the encoded fieldKey values. |
| packages/components/src/internal/app/utils.ts | Adds headerURLParams to various menu configuration functions for preserving sort parameters. |
| packages/components/releaseNotes/components.md | Documents the fixes for Issue 52979 and Issue 52472 in the release notes. |
Files not reviewed (2)
- packages/components/package-lock.json: Language not supported
- packages/components/package.json: Language not supported
Comments suppressed due to low confidence (2)
packages/components/src/public/QueryModel/CustomizeGridViewModal.tsx:37
- Verify that replacing column.index with column.fieldKeyPath consistently provides the expected encoded value for the lookup field across all usages.
fk: column.fieldKeyPath, // Issue 52979: use encoded fieldKeyPath
packages/components/src/public/QueryModel/CustomizeGridViewModal.tsx:42
- Confirm that comparing column.fieldKey with QueryColumn.ANCESTORS_PREFIX is appropriate, ensuring the condition aligns with the use of fieldKeyPath for lookup expansion.
if (column.fieldKey === QueryColumn.ANCESTORS_PREFIX && queryInfo.schemaQuery.schemaName === SCHEMAS.DATA_CLASSES.SCHEMA) {
labkey-susanh
approved these changes
May 1, 2025
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 52979: App grid customize view doesn't expand lookup field with special char
Issue 52472: Re-clicking the Source Types, Sample Types or Assay links in the mega menu removes the sort=Name parameter from the url
Related Pull Requests
Changes