Issue 53148: Uncaught TypeError from webkitGetAsEntry()#1798
Merged
labkey-nicka merged 9 commits intodevelopfrom May 28, 2025
Merged
Issue 53148: Uncaught TypeError from webkitGetAsEntry()#1798labkey-nicka merged 9 commits intodevelopfrom
labkey-nicka merged 9 commits intodevelopfrom
Conversation
labkey-nicka
force-pushed
the
fb_jnk_except
branch
from
012cffd to
3d521bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses Issue 53148 by coalescing logic around calls to
webkitGetAsEntry()in a utility methodgetTransferItemDirectoryEntry().Related Pull Requests
Changes
getTransferItemDirectoryEntryto centralize handling/wrapping of callingwebkitGetAsEntry()on aDataTransferItemListitem. Update all usages to call this.