Reduce logging for SQL exceptions from queries with calculated columns#1840
Merged
Reduce logging for SQL exceptions from queries with calculated columns#1840
Conversation
…olumn SQL errors - add comment tag to executeSql query to indicate it is from a calculated column validation
3 tasks
labkey-nicka
approved these changes
Aug 7, 2025
# Conflicts: # packages/components/package-lock.json # packages/components/package.json
…olumn() temp data
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We have a few open issues related to the logging for calculated column errors / exceptions:
Issue 52026: Calculated column validation incorrectly flags expressions containing CAST
Issue 51862: Invalid calculated columns on DataClass breaks indexing and viewing in LKS grid
This PR looks to reduce that logging by adding a CALCULATED_COLUMN_SQL_TAG to the SQL query for the validation API check and the inclusion of the calc columns in the table. We then look for that tag in the handleSqlException() method.
Related Pull Requests
Changes