Fix various issues with selections#1841
Merged
labkey-alan merged 35 commits intodevelopfrom Sep 8, 2025
Merged
Conversation
labkey-alan
force-pushed
the
fb_selection_issues
branch
from
90d03e5 to
3ac158e
Compare
labkey-alan
force-pushed
the
fb_selection_issues
branch
2 times, most recently
from
47bfa51 to
97556c1
Compare
labkey-nicka
approved these changes
Aug 29, 2025
labkey-alan
force-pushed
the
fb_selection_issues
branch
from
b5648ce to
42e701d
Compare
cnathe
approved these changes
Sep 2, 2025
| selected {noun}. | ||
| </p> | ||
| {this.getSelectionCount() > 1 && onSubmitForEdit && ( | ||
| <p>To update individual {noun} in this selection group, select "Edit with Grid".</p> |
Contributor
There was a problem hiding this comment.
I thought we had already taken out all of this "Edit with Grid" code? huh, must have missed some. Thanks for cleaning up.
| sampleFieldKey?: string; | ||
| sampleIds?: number[]; | ||
| schemaQuery?: SchemaQuery; | ||
| selectedRowIds?: number[] | string[]; |
Contributor
There was a problem hiding this comment.
I can't recall when we talked about this last, but don't we want these rowId related props to be number[] only and make the caller responsible for converting string to number as early as possible?
Contributor
Author
There was a problem hiding this comment.
FreezerManager makes it really difficult to accomplish that, because it provides numbers. If I change FM to only pass strings I then also have to touch a lot of other downstream components to accept strings, which explodes the surface area of the changes, and I think would add unnecessary complexity to this PR, and potentially introduce subtle runtime issues.
- Partial Fix for Issue 53378
- Don't rely on selectionKey - Don't rely on QueryModel - Add usePicklistSelections to get rid of duplicate selection loading logic - Update AddToPicklistMenuItem, PicklistCreationMenuItem
re-add error logging refactor deletePicklists to use async request
All usages were using EntityBulkUpdateAlert, but that is in ui-premium. Code has been moved here so consumers don't need to manually wire up the warnings.
- Necessary to handle deleted/missing selections
…hotSelection argument
…are no selected rows
Fix issue with PicklistCreationMenuItem being incorrectly disabled when acting as a button
AssayImportDropdownSection - Fix issue with crossfolder selections in subfolders
labkey-alan
force-pushed
the
fb_selection_issues
branch
from
ae33ebe to
c44cfbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR fixes issues when users take actions with selections see issues:
Related Pull Requests
Changes