DatePickerInput: don't add ms to default date#1851
Merged
labkey-alan merged 5 commits intodevelopfrom Sep 12, 2025
Merged
Conversation
XingY
approved these changes
Sep 11, 2025
XingY
reviewed
Sep 11, 2025
| * | ||
| * See Issue 53577 | ||
| */ | ||
| getOpenToDate = (): Date => { |
Contributor
There was a problem hiding this comment.
With this change can we now get rid of the workaround around line 164?
if (!event && !raw && date?.getMilliseconds() > 0) {
date.setMilliseconds(0); // react-datepicker milliseconds are not 0 when selecting time
}
Contributor
Author
There was a problem hiding this comment.
Yes, good catch. I have verified my fix still works without that change.
labkey-nicka
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR addresses Issue 53577
Related Pull Requests
Changes